Don't offer to hard reset Firefly #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolot27
approved these changes
Aug 13, 2021
app/src/main/java/com/eveningoutpost/dexdrip/G5Model/Ob1G5StateMachine.java
Outdated
Show resolved
Hide resolved
jamorham
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this
It's confusing if the user of a Firefly G6 sees an offer to hard reset transmitter.
This PR removes the offer, if the transmitter is a Firefly, and replaces it with a log.
Over the period of 3 years, I have only seen may be 5 cases of this on facebook. The last time was less than a month or so ago. But, I'm not sure what xDrip version they were using.
This is one of the actions listed in this issue: #1736
Is there a workaround?
The user can ignore the message if they are knowledgeable that xDrip has not been updated after the G6 firmware change.
Are there any side effects?
No
Tests
I am running this build on my main device now. But, I don't know how to trigger the error that would execute the new conditional.