-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the ability to set vibration patterns per individual alerts #2142
base: master
Are you sure you want to change the base?
Conversation
erobinson
commented
May 23, 2022
•
edited
Loading
edited
- Adding the ability to set vibration patterns per individual alerts.
- This makes it easier to nudge when 130, alert when 160, and alert very loudly when 200 or 60.
- This is also super helpful for phones w/ strong vibration motors where the default vibration is VERY loud.
- Tested by creating various alerts and checking the vibrations when triggered. Also can just test the alert when creating.
- NOTE: I only tested this on a Pixel 6 Pro w/ Wear OS watch. Not tested with other devices, smart watches, and fitness trackers.
Could we use 0,100,50,100,50,100,50,100,50,100,50,100 for low or as additional pattern? |
Added as an extra option. |
Looks very good. What exactly happens if someone installs xDrip for the very first time after this? What will the vibration type be set to by default? Will it be identical to the current vibration pattern before this PR? Have you tested this in conjunction with the Ascending volume profile? Disabling "Vibrate on alert" disables them all, right? I don't know if we have a standard method for marking the default. May be @tolot27 can tell us. I have used > as a marker for the default in a PR that has not been merged. So, I cannot tell you to use it unless we can an approval. |
I have no knowledge of java but couldn't one use arrays or lists to generate all the radio buttons and vibration patterns as there seems to be so many code repetitions? Not sure what is stored after clicking save but if you stored the pattern itself, you could create an input so others could type in custom pattern. |
How is it going? Still looking very forward to this feature. |
What is the problem with the PR? I'd love to use this feature |
Yea, same, still waiting this to be implemented. |
@erobinson How would you feel about creating a sub page that would contain everything related to the vibration patterns? I am happy to collaborate with you on this as well. |