Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.reflections library #28

Merged
merged 2 commits into from
Jan 19, 2018
Merged

Update org.reflections library #28

merged 2 commits into from
Jan 19, 2018

Conversation

nicmunroe
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 19, 2018

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage     95.27%   95.27%           
  Complexity      739      739           
=========================================
  Files            71       71           
  Lines          2033     2033           
  Branches        331      331           
=========================================
  Hits           1937     1937           
  Misses           59       59           
  Partials         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dca28f...d993df4. Read the comment docs.

@nicmunroe
Copy link
Member Author

The following error was showing up when a project relied on backstopper-reusable-tests but also a newer version of org.reflections:reflections than what backstopper was compiled with: NoSuchMethodError: org.reflections.util.ClasspathHelper.forPackage(Ljava/lang/String;[Ljava/lang/ClassLoader;)Ljava/util/Set;.

For example I ran into this when using Kotlin in a Backstopper-powered project because Kotlin was pulling in org.reflections:reflections:0.9.11. Compiling backstopper with the latest org.reflections:reflections version seems to fix the issue.

@nicmunroe nicmunroe merged commit 8c4fd89 into Nike-Inc:master Jan 19, 2018
@nicmunroe nicmunroe deleted the misc branch January 8, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants