Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backstopper 2.0 - Refactor code from javax ecosystem to jakarta, drop old modules, and pin to java 17 #72

Merged
merged 42 commits into from
Sep 13, 2024

Conversation

nicmunroe
Copy link
Member

No description provided.

…testing, and add a testonly-springboot3_3-webflux module
@nicmunroe nicmunroe force-pushed the feature/javax-to-jakarta-transition branch from 7bfc850 to dd76d5c Compare September 13, 2024 20:23
@nicmunroe nicmunroe force-pushed the feature/javax-to-jakarta-transition branch from dd76d5c to 35b07da Compare September 13, 2024 20:26
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 91.80328% with 20 lines in your changes missing coverage. Please review.

Project coverage is 88.14%. Comparing base (dcbcad4) to head (9f385ee).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
...SpringCommonFrameworkExceptionHandlerListener.java 93.57% 2 Missing and 7 partials ⚠️
.../nike/backstopper/service/NoOpJsr303Validator.java 16.66% 5 Missing ⚠️
...SpringWebMvcFrameworkExceptionHandlerListener.java 86.66% 1 Missing and 1 partial ⚠️
...stopper/handler/UnhandledExceptionHandlerBase.java 0.00% 1 Missing ⚠️
...aints/impl/StringConvertsToClassTypeValidator.java 85.71% 0 Missing and 1 partial ⚠️
...yJsr303ValidationMessagesPointToApiErrorsTest.java 50.00% 0 Missing and 1 partial ⚠️
...ndler/spring/webflux/DisconnectedClientHelper.java 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #72      +/-   ##
============================================
- Coverage     92.58%   88.14%   -4.44%     
+ Complexity      495      131     -364     
============================================
  Files           144      113      -31     
  Lines          3749     2919     -830     
  Branches        484      394      -90     
============================================
- Hits           3471     2573     -898     
- Misses          233      311      +78     
+ Partials         45       35      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicmunroe nicmunroe merged commit 6da4fed into Nike-Inc:main Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant