This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Feat/migrate to gh actions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunderwood
requested review from
jharen,
shawn-sher,
jiangha4,
rdong333 and
melanahammel
melanahammel
approved these changes
Nov 17, 2020
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up Python ${{ matrix.python-version }} |
There was a problem hiding this comment.
Does this work to set up both version of Python?
There was a problem hiding this comment.
Yes, it looks at the "strategy:matrix:python-version" field under Build and then creates separate workflows for each one.
| uses: codecov/codecov-action@v1 | ||
| with: | ||
| file: coverage.xml # optional | ||
| fail_ci_if_error: true # optional (default = false) |
There was a problem hiding this comment.
Will this send a Slack notification if any tests fail?
There was a problem hiding this comment.
I had actually forgotten to put the slack config in so thanks for catching that.
This will notify us in slack anytime the master build fails (due to failed tests, failed coverage upload, or anything else)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.