Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple calls to Server.shutdown() #118

Merged

Conversation

nicmunroe
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #118 into master will decrease coverage by 0.05%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
- Coverage     91.48%   91.43%   -0.06%     
- Complexity     2344     2345       +1     
============================================
  Files           161      161              
  Lines          6730     6735       +5     
  Branches        889      889              
============================================
+ Hits           6157     6158       +1     
- Misses          381      383       +2     
- Partials        192      194       +2
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/nike/riposte/server/Server.java 74.31% <70%> (+2.19%) 15 <7> (+4) ⬆️
...mpipeline/DownstreamIdleChannelTimeoutHandler.java 85% <0%> (-5%) 4% <0%> (-1%)
...ient/asynchttp/netty/StreamingAsyncHttpClient.java 73.33% <0%> (-0.61%) 49% <0%> (-1%)
...r/handler/ProxyRouterEndpointExecutionHandler.java 60.86% <0%> (-0.32%) 26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec6501...f62b770. Read the comment docs.

@nicmunroe nicmunroe merged commit c5e2f7e into Nike-Inc:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants