Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability annotations to APIs commonly used by services #119

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

nicmunroe
Copy link
Member

This significantly improves kotlin support.

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #119 into master will decrease coverage by 0.19%.
The diff coverage is 94.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #119     +/-   ##
===========================================
- Coverage     91.71%   91.52%   -0.2%     
- Complexity     2348     2373     +25     
===========================================
  Files           161      161             
  Lines          6735     6817     +82     
  Branches        889      916     +27     
===========================================
+ Hits           6177     6239     +62     
- Misses          366      386     +20     
  Partials        192      192
Impacted Files Coverage Δ Complexity Δ
...ver/error/validation/RequestSecurityValidator.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...riposte/config/BackstopperRiposteConfigHelper.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...oste/server/handler/SecurityValidationHandler.java 75% <ø> (ø) 15 <0> (ø) ⬇️
...e/server/http/filter/RequestAndResponseFilter.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...c/main/java/com/nike/riposte/util/MatcherUtil.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...oste/metrics/codahale/CodahaleMetricsListener.java 100% <ø> (ø) 40 <0> (ø) ⬇️
...ike/riposte/server/http/impl/BaseResponseInfo.java 100% <ø> (ø) 25 <0> (ø) ⬇️
...e/serviceregistration/eureka/EurekaServerHook.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...erver/handler/RequestContentValidationHandler.java 100% <ø> (ø) 19 <0> (ø) ⬇️
...ava/com/nike/riposte/metrics/MetricsCollector.java 100% <ø> (ø) 12 <0> (ø) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e2f7e...65e7b6a. Read the comment docs.

This significantly improves kotlin support.
@nicmunroe nicmunroe force-pushed the feature/better-kotlin-support branch from 2ecac7c to 65e7b6a Compare March 1, 2019 23:38
@nicmunroe nicmunroe merged commit b01a1ec into Nike-Inc:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants