Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add riposte-async-http-client2 module that uses async http client 2.x #122

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

rabeyta
Copy link
Contributor

@rabeyta rabeyta commented May 23, 2019

started with riposte-async-http-client and switched out async http client 1.x for 2.x

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #122 into master will increase coverage by 0.27%.
The diff coverage is 98.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     91.53%   91.81%   +0.27%     
- Complexity     2350     2457     +107     
============================================
  Files           161      167       +6     
  Lines          6806     7119     +313     
  Branches        920      950      +30     
============================================
+ Hits           6230     6536     +306     
- Misses          385      388       +3     
- Partials        191      195       +4
Impacted Files Coverage Δ Complexity Δ
...iposte/client/asynchttp/RequestBuilderWrapper.java 100% <100%> (ø) 11 <11> (?)
...cHttpClientHelperSpanNamingAndTaggingStrategy.java 100% <100%> (ø) 10 <10> (?)
...syncCompletionHandlerWithTracingAndMdcSupport.java 100% <100%> (ø) 17 <17> (?)
...ent/asynchttp/AsyncHttpClientHelperTagAdapter.java 93.93% <93.93%> (ø) 19 <19> (?)
...om/nike/riposte/client/asynchttp/util/AwsUtil.java 96.55% <96.55%> (ø) 20 <20> (?)
...iposte/client/asynchttp/AsyncHttpClientHelper.java 98.26% <98.26%> (ø) 31 <31> (?)
.../com/nike/riposte/server/logging/AccessLogger.java 94.77% <0%> (-1.5%) 47% <0%> (-1%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68d86e...330bc21. Read the comment docs.

@rabeyta rabeyta force-pushed the asyncHttpClient2Module branch 2 times, most recently from 7251aae to ac51c1c Compare May 24, 2019 17:05
@nicmunroe nicmunroe merged commit 03f9f45 into Nike-Inc:master Jun 4, 2019
@nicmunroe
Copy link
Member

Thanks for doing this @rabeyta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants