Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle to 5.4.1 and get rid of reliance on plugins for console summaries #124

Merged
merged 10 commits into from
May 23, 2019

Conversation

nicmunroe
Copy link
Member

No description provided.

@nicmunroe nicmunroe mentioned this pull request May 23, 2019
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #124 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     91.41%   91.73%   +0.31%     
+ Complexity     2370     2350      -20     
============================================
  Files           161      161              
  Lines          6817     6785      -32     
  Branches        916      916              
============================================
- Hits           6232     6224       -8     
+ Misses          389      370      -19     
+ Partials        196      191       -5
Impacted Files Coverage Δ Complexity Δ
...ste/metrics/codahale/CodahaleMetricsCollector.java 95.4% <0%> (-0.44%) 30% <0%> (ø)
.../src/main/java/com/nike/riposte/server/Server.java 74.77% <0%> (-0.23%) 15% <0%> (ø)
...ike/riposte/util/text/parsercombinator/Parser.java 89.37% <0%> (-0.08%) 18% <0%> (ø)
...iposte/typesafeconfig/util/TypesafeConfigUtil.java 100% <0%> (ø) 2% <0%> (-1%) ⬇️
...perwrapper/BiConsumerWithTracingAndMdcSupport.java 100% <0%> (ø) 7% <0%> (ø) ⬇️
...oste/server/channelpipeline/ChannelAttributes.java 100% <0%> (ø) 3% <0%> (-1%) ⬇️
...elperwrapper/ConsumerWithTracingAndMdcSupport.java 100% <0%> (ø) 7% <0%> (ø) ⬇️
...rapper/ChannelFutureListenerWithTracingAndMdc.java 100% <0%> (ø) 7% <0%> (ø) ⬇️
...elperwrapper/RunnableWithTracingAndMdcSupport.java 100% <0%> (ø) 7% <0%> (ø) ⬇️
...e/client/asynchttp/ning/AsyncHttpClientHelper.java 98.14% <0%> (+0.9%) 36% <0%> (-10%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454f528...6403fcb. Read the comment docs.

@nicmunroe nicmunroe merged commit 80edb9f into Nike-Inc:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants