Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform better handling when errors occur during response sending #133

Merged
merged 1 commit into from
May 28, 2020

Conversation

nicmunroe
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #133 into master will increase coverage by 0.50%.
The diff coverage is 97.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
+ Coverage     91.99%   92.49%   +0.50%     
- Complexity     2486     2517      +31     
============================================
  Files           167      167              
  Lines          7167     7237      +70     
  Branches        963      979      +16     
============================================
+ Hits           6593     6694     +101     
+ Misses          381      352      -29     
+ Partials        193      191       -2     
Impacted Files Coverage Δ Complexity Δ
.../riposte/server/handler/ResponseSenderHandler.java 97.08% <96.62%> (+27.31%) 34.00 <31.00> (+22.00)
...erver/handler/ChannelPipelineFinalizerHandler.java 100.00% <100.00%> (ø) 53.00 <0.00> (+3.00)
...poste/server/handler/RequestInfoSetterHandler.java 85.29% <100.00%> (ø) 14.00 <0.00> (+1.00)
...ient/asynchttp/netty/StreamingAsyncHttpClient.java 77.55% <0.00%> (+1.18%) 57.00% <0.00%> (+2.00%)
.../com/nike/riposte/server/logging/AccessLogger.java 96.26% <0.00%> (+1.49%) 48.00% <0.00%> (+1.00%)
...r/handler/ProxyRouterEndpointExecutionHandler.java 64.35% <0.00%> (+3.47%) 28.00% <0.00%> (+1.00%)
...ke/riposte/server/handler/AccessLogEndHandler.java 96.66% <0.00%> (+6.66%) 12.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58383df...806b6ed. Read the comment docs.

@nicmunroe nicmunroe merged commit 6a8c924 into Nike-Inc:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants