Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignalFx-aware CodahaleMetricsCollector #65

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

nicmunroe
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #65 into master will increase coverage by 0.03%.
The diff coverage is 98.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     90.71%   90.75%   +0.03%     
- Complexity     1999     2009      +10     
============================================
  Files           142      143       +1     
  Lines          5893     5929      +36     
  Branches        781      781              
============================================
+ Hits           5346     5381      +35     
- Misses          368      369       +1     
  Partials        179      179
Impacted Files Coverage Δ Complexity Δ
...odahale/SignalFxAwareCodahaleMetricsCollector.java 100% <100%> (ø) 7 <7> (?)
.../codahale/impl/SignalFxEndpointMetricsHandler.java 100% <100%> (ø) 22 <0> (ø) ⬇️
...ste/metrics/codahale/CodahaleMetricsCollector.java 95.69% <95.45%> (-0.94%) 28 <21> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5c0b8...82e2055. Read the comment docs.

@nicmunroe nicmunroe merged commit 9f6ebfc into Nike-Inc:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants