Add support for 403 responses #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.71% (diff: 100%)@@ master #7 diff @@
==========================================
Files 134 135 +1
Lines 5255 5271 +16
Methods 0 0
Messages 0 0
Branches 866 867 +1
==========================================
+ Hits 4661 4676 +15
- Misses 399 400 +1
Partials 195 195
|
nicmunroe
reviewed
Nov 22, 2016
| } | ||
|
|
||
| @Test | ||
| public void should_honor_constructor_params() { |
There was a problem hiding this comment.
There appear to be tabs mixed with spaces in this file (and maybe others?). Please fix so they're all spaces. Otherwise looks great!
|
tabs removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change allows 403 responses to be returned similar to the other 4xx HTTP responses.