Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for raw byte array as a request input type #86

Merged

Conversation

nicmunroe
Copy link
Member

Also added some extra exception message and cause details to riposte-backstopper framework listener for various exceptions

@nicmunroe nicmunroe force-pushed the bugfix/byte-array-content-deserialization branch 2 times, most recently from d56315a to f6d08f0 Compare January 31, 2018 00:10
Also add some extra exception message and cause details to riposte-backstopper framework listener for various exceptions, and try to fix intermittent test on Travis CI
@nicmunroe nicmunroe force-pushed the bugfix/byte-array-content-deserialization branch from f6d08f0 to 052006c Compare January 31, 2018 00:38
@codecov-io
Copy link

codecov-io commented Jan 31, 2018

Codecov Report

Merging #86 into master will decrease coverage by 0.01%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     91.06%   91.04%   -0.02%     
- Complexity     2060     2063       +3     
============================================
  Files           146      146              
  Lines          5990     5999       +9     
  Branches        786      788       +2     
============================================
+ Hits           5455     5462       +7     
+ Misses          360      359       -1     
- Partials        175      178       +3
Impacted Files Coverage Δ Complexity Δ
...nike/riposte/server/http/impl/RequestInfoImpl.java 100% <100%> (ø) 72 <0> (+1) ⬆️
...ckstopperRiposteFrameworkErrorHandlerListener.java 99.37% <96.55%> (-0.63%) 33 <3> (+2)
...ient/asynchttp/netty/StreamingAsyncHttpClient.java 74.71% <0%> (-0.92%) 43% <0%> (-1%)
...r/handler/ProxyRouterEndpointExecutionHandler.java 61.19% <0%> (+0.31%) 26% <0%> (ø) ⬇️
.../com/nike/riposte/server/logging/AccessLogger.java 96.32% <0%> (+1.47%) 47% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfcbcd0...052006c. Read the comment docs.

@nicmunroe nicmunroe merged commit b595ab6 into Nike-Inc:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants