Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/access logger corner cases #93

Merged

Conversation

nicmunroe
Copy link
Member

@nicmunroe nicmunroe commented Feb 13, 2018

  • Firms up tracking when requests start and end, and at a higher granularity (nanoseconds).
  • Also tracks when the last payload chunk arrives (allows you to diagnose when slow response times are due to callers slowly trickling in their payloads).
  • Removes span name from access logger output defaults - callers shouldn't be sending this and it's a waste of characters in the log message.
  • Handles corner cases so that access logging is always performed, e.g. when the caller drops connection before the response has been sent.

…ing-for-payload-chunks values

Also set response end time on the HTTP processing state so that numbers are consistent across different areas of code like access logger and metrics
@nicmunroe nicmunroe merged commit 7455ddc into Nike-Inc:master Feb 14, 2018
@codecov-io
Copy link

Codecov Report

Merging #93 into master will increase coverage by 0.07%.
The diff coverage is 97.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
+ Coverage      91.3%   91.37%   +0.07%     
- Complexity     2091     2109      +18     
============================================
  Files           148      148              
  Lines          6070     6109      +39     
  Branches        794      799       +5     
============================================
+ Hits           5542     5582      +40     
+ Misses          356      355       -1     
  Partials        172      172
Impacted Files Coverage Δ Complexity Δ
...server/channelpipeline/HttpChannelInitializer.java 100% <ø> (ø) 30 <0> (ø) ⬇️
...oste/metrics/codahale/CodahaleMetricsListener.java 100% <100%> (ø) 40 <0> (ø) ⬇️
...a/com/nike/riposte/server/http/ResponseSender.java 73.51% <100%> (+0.12%) 61 <1> (+1) ⬆️
...ke/riposte/server/handler/AccessLogEndHandler.java 90% <100%> (ø) 11 <0> (ø) ⬇️
.../com/nike/riposte/server/logging/AccessLogger.java 96.29% <100%> (+1.44%) 48 <0> (+2) ⬆️
.../riposte/server/handler/AccessLogStartHandler.java 100% <100%> (ø) 9 <2> (+3) ⬆️
...erver/handler/ChannelPipelineFinalizerHandler.java 100% <100%> (ø) 46 <0> (+3) ⬆️
.../nike/riposte/server/http/HttpProcessingState.java 99.01% <94.73%> (+1.42%) 45 <9> (+10) ⬆️
...mpipeline/DownstreamIdleChannelTimeoutHandler.java 85% <0%> (-5%) 4% <0%> (-1%)
...ient/asynchttp/netty/StreamingAsyncHttpClient.java 75.52% <0%> (-0.24%) 46% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e4b1a...896f47f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants