Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiregion config files #96

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

jcnorman48
Copy link

allow the appid and environment to be overriden when loading the typesafe config files

@codecov-io
Copy link

codecov-io commented Feb 26, 2018

Codecov Report

Merging #96 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     91.45%   91.42%   -0.04%     
  Complexity     2118     2118              
============================================
  Files           148      148              
  Lines          6132     6133       +1     
  Branches        803      803              
============================================
- Hits           5608     5607       -1     
- Misses          353      354       +1     
- Partials        171      172       +1
Impacted Files Coverage Δ Complexity Δ
...e/riposte/typesafeconfig/TypesafeConfigServer.java 100% <100%> (ø) 9 <1> (+1) ⬆️
.../com/nike/riposte/server/logging/AccessLogger.java 94.81% <0%> (-1.49%) 47% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2070e...3fa55cf. Read the comment docs.

@nicmunroe
Copy link
Member

Looks good, thank you!

@nicmunroe nicmunroe merged commit 998ae26 into Nike-Inc:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants