Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] target_table_name key error #17

Closed
Umeshsp22 opened this issue Aug 22, 2023 · 0 comments
Closed

[BUG] target_table_name key error #17

Umeshsp22 opened this issue Aug 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Umeshsp22
Copy link
Collaborator

Describe the bug
Spark-expectations terminates with target_table_name key error

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/Nike-Inc/spark-expectations/blob/78c47598082c96332e5755427a6c767ae22faa0d/spark_expectations/examples/sample_dq.py#L34C28-L34C57
  2. replace target_table_name with test, run and See error

Expected behavior
When No rules has been set for the target_table in the rule table. spark-expectations framework should terminate with appropriate message

Screenshots
image
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
@Umeshsp22 Umeshsp22 added the bug Something isn't working label Aug 22, 2023
@Umeshsp22 Umeshsp22 mentioned this issue Aug 22, 2023
9 tasks
asingamaneni pushed a commit that referenced this issue May 29, 2024
* Initializing theme files (#11)

* Adding a basic mantine theme file. It will be updated as the code base develops.

Any colors or gaps will not be hardcoded.

They should first be defined in the theme and then should be used in the code.

* updating .gitignore

* Includes a comprehensive test setup with mock data and support structure. (#12)

setting up tests in the future will be easier.

* 9 tech debt setup public private routing (#13)

* Working version of routing

* Implemented routing, however tests for the login page needs to figured out.

* implemented notification from mantine (#14)

* 8 feature implement login functionality using GitHub oauth (#15)

* clean up

* A simple but beautiful login page

* Github Oauth setup

* 16 tech debt complete todos (#17)

* Fixed testing setup and have all tests for OAuth.

* Fixed remaining TODOs, added tests.

* Adding a DEVELOPER.md and .env.example
asingamaneni added a commit that referenced this issue Jul 29, 2024
* Merge pull request #1

* Base setup for react ui

* Merge pull request #2

* Zustand + React Query setup

* Integrating Zustand, RQ and api.github with a basic implementation

* Completed the mantine + dev tooling setup and implemented a layout  (#3)

* Local test, vite, linting and prettier setup.
Switching to mantine instead of material ui

* Updating readme.md with run scripts details

* Adding basic app layout with mantine

* Adding auth provider which shows a modal for users to enter their github token (#4)

* GitHub Integration + Render Repos List And User Card  (#5)

* 1. Segregating header into a new component
2. Updating header with new styles

* Implement a ReposList component with dropdown.
Supports smooth scrolling and autocomplete search
ReposList shows in Header component.

* Implemented a UserButton Component.
UserButton is in Header

* Implemented use repos
Integrated it with ReposList

Implemented useUser
Integrated it with UserButton

* Update Readme.md

* Reverting IDE changes

* 1. Improved token handling
2. Improved api-client
3. Added a Loading component

* Linting fixes

* Failed attempt at wrapping Error and Loading using a HOC. Will investigate this later.

* Updates to Header and UserMenu

* Add a sample NavBar

* updating tests

* Implement Base Structure and GitHub OAuth Login (#97)

* Initializing theme files (#11)

* Adding a basic mantine theme file. It will be updated as the code base develops.

Any colors or gaps will not be hardcoded.

They should first be defined in the theme and then should be used in the code.

* updating .gitignore

* Includes a comprehensive test setup with mock data and support structure. (#12)

setting up tests in the future will be easier.

* 9 tech debt setup public private routing (#13)

* Working version of routing

* Implemented routing, however tests for the login page needs to figured out.

* implemented notification from mantine (#14)

* 8 feature implement login functionality using GitHub oauth (#15)

* clean up

* A simple but beautiful login page

* Github Oauth setup

* 16 tech debt complete todos (#17)

* Fixed testing setup and have all tests for OAuth.

* Fixed remaining TODOs, added tests.

* Adding a DEVELOPER.md and .env.example

* Initializing theme files (#11)

* Adding a basic mantine theme file. It will be updated as the code base develops.

Any colors or gaps will not be hardcoded.

They should first be defined in the theme and then should be used in the code.

* updating .gitignore

* Includes a comprehensive test setup with mock data and support structure. (#12)

setting up tests in the future will be easier.

* 9 tech debt setup public private routing (#13)

* Working version of routing

* Implemented routing, however tests for the login page needs to figured out.

* implemented notification from mantine (#14)

* 8 feature implement login functionality using GitHub oauth (#15)

* clean up

* A simple but beautiful login page

* Github Oauth setup

* 16 tech debt complete todos (#17)

* Fixed testing setup and have all tests for OAuth.

* Fixed remaining TODOs, added tests.

* Adding a DEVELOPER.md and .env.example

* Restructuring + layout (#19)

* adding yaml file

* 20 load list of organizations on the left cell (#21)

* WIP

* fetch user name before rendering main page

* implement api for user repos

* show available repos on the left hand side

* Rendering an un nested list of files

* rendering yaml files in each project

* implemented rules table

* editing rules.yaml

* Build a working version (#22)

* working modal

* working flow

* Updated repos list

* Refactored CommitsList.tsx and apis

* minor fixes

* clean up

---------

Co-authored-by: Ashok Singamaneni <ashok.singamaneni@nike.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants