Reverting error_df optimization to fix #101 #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the sequence_nbr optimization logic in writer.py
Related Issue
#101
Motivation and Context
This change reverts a change to write_error_records_final() that caused error metrics to be lower than the actual errors.
How Has This Been Tested?
Tested with Databricks runtime 14.3 LTS and Spark 3.5.0
Compared and matched stats table, error table output with actual errors for 50 row_dqs on a 500 million record dataset.
Performance was not slower than v2.1.0 for this use case.
Screenshots (if appropriate):
Types of changes
Checklist: