Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting error_df optimization to fix #101 #104

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

shinga
Copy link
Contributor

@shinga shinga commented Jul 9, 2024

Description

Removes the sequence_nbr optimization logic in writer.py

Related Issue

#101

Motivation and Context

This change reverts a change to write_error_records_final() that caused error metrics to be lower than the actual errors.

How Has This Been Tested?

Tested with Databricks runtime 14.3 LTS and Spark 3.5.0
Compared and matched stats table, error table output with actual errors for 50 row_dqs on a 500 million record dataset.
Performance was not slower than v2.1.0 for this use case.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shinga shinga marked this pull request as ready for review July 9, 2024 21:34
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit d860ae5 into Nike-Inc:main Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants