Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#87 Enable Users to Customize Email Body Modification #119

Merged

Conversation

Jennikon
Copy link
Contributor

@Jennikon Jennikon commented Dec 11, 2024

Description

Add possibility for user to provide his custom email body with parametrized dq stats.
For now only string custom email body is available.
User can import in custom body following statistics:
'product_id'
'table_name'
'input_count'
'error_count'
'output_count'
'output_percentage'
'success_percentage'
'error_percentage'
'source_agg_dq_results'
'final_agg_dq_results'
'source_query_dq_results'
'final_query_dq_results'
'row_dq_res_summary'
'row_dq_error_threshold'
'dq_status'
'dq_run_time'
'dq_rules'
'meta_dq_run_id'
'meta_dq_run_date'
'meta_dq_run_datetime'

To be able to import above mentioned statistics user should comply to the following syntax pattern:
"custom message 'dq_status': {}, 'dq_rules': {}, ..."
or
'''
custom message
'dq_status': {},
'dq_rules': {},
...
'''

Related Issue

(#87)

Motivation and Context

There was user request for providing the possibility for the user to construct custom email body and have in notifications custom statistics

How Has This Been Tested?

Tested locally with the help of local smtp debugging server

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Jennikon Jennikon marked this pull request as draft December 11, 2024 12:22
@Jennikon Jennikon marked this pull request as ready for review December 18, 2024 13:07
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@asingamaneni asingamaneni merged commit 5c7be0a into Nike-Inc:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants