Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting spark udf's to native functions #26

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Converting spark udf's to native functions #26

merged 6 commits into from
Sep 11, 2023

Conversation

phanikumarvemuri
Copy link
Contributor

This PR is to address issue #6 . It removes duplicate code and converts udfs to spark native functions for performance.

Description

This removes setting dq results twice to the context and also convert udfs remove_empty_maps and get_action_list to native functions using filter and transform.

Related Issue

#6

How Has This Been Tested?

Tested Locally

Screenshots (if appropriate):

Screenshot 2023-09-09 at 10 42 38 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a396979) 100.00% compared to head (b7dcf1d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1369      1362    -7     
=========================================
- Hits          1369      1362    -7     
Files Changed Coverage Δ
spark_expectations/core/expectations.py 100.00% <ø> (ø)
spark_expectations/utils/udf.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for suggesting and making the improvements.

@asingamaneni asingamaneni merged commit 915fffc into Nike-Inc:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants