Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature remove mandatory args #40

Merged
merged 31 commits into from
Sep 28, 2023
Merged

Feature remove mandatory args #40

merged 31 commits into from
Sep 28, 2023

Conversation

asingamaneni
Copy link
Collaborator

Description

There are many changes made by me and @phanikumarvemuri in this pr. Have made it concise, Extended to write to any source which spark supports and other bugs

Related Issue

#39
#37
#35
#34
#32
#29
#27
#28
#14
#13

Motivation and Context

Based on the feedback from the users and to make the tool better

How Has This Been Tested?

UnitTested Locally

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

asingamaneni and others added 30 commits September 13, 2023 02:34
@asingamaneni
making changes and refactoring the code. yet to modify unittests for …
f198994 
…expectations.py
@asingamaneni
Adding Wrapped DataFrameWriter and unitests for the same
9c3e589
@asingamaneni
ignoring the mypy to be in sync with pyspark
ced4a59
@asingamaneni
ignoring agg_dq and query_dq
59c2462
@asingamaneni
Rearranging lot of code, removed delta. Enabled custom writers in dif…
f043b33 
…ferent formats
@asingamaneni
making changes and refactoring the code. yet to modify unittests for …
6b6fe74 
…expectations.py
@asingamaneni
Adding Wrapped DataFrameWriter and unitests for the same
3eeda22
@asingamaneni
ignoring the mypy to be in sync with pyspark
680a060
@asingamaneni
ignoring agg_dq and query_dq
0376f84
@asingamaneni
Rearranging lot of code, removed delta. Enabled custom writers in dif…
0c347d9 
…ferent formats
@asingamaneni
Merge branch 'Nike-Inc:feature-remove-mandatory-args' into feature-re…
1172ec0 
…move-mandatory-args
@asingamaneni
fixing tests for the sinks and updating README
8f2235d
@asingamaneni
fixing kafka configurations
988c826
@asingamaneni
Merge branch 'Nike-Inc:feature-remove-mandatory-args' into feature-re…
959bf46 
…move-mandatory-args
@asingamaneni @phanikumarvemuri
Feature add reader (#1)
c37bfd1 
* changing rules table along with few other changes

* reader and writer modifications

---------

Co-authored-by: phanikumarvemuri <phaniv99@gmail.com>
@asingamaneni
Updating formatting, removing delta as dependency
1bba704
@asingamaneni
Updating examples
37c1986
@asingamaneni
started unitests
9043741
@asingamaneni
Adding more tests
42cdf1a
@asingamaneni
first test succesful for with_expectations, rest will follow through
ce17b20
@asingamaneni
Adding examples for expectations
35b5d8e
@asingamaneni
adding documentation
584c6de
@asingamaneni @phanikumarvemuri
adding test cases (#2)
3451515 
Co-authored-by: phanikumarvemuri <phaniv99@gmail.com>
@asingamaneni
Merge remote-tracking branch 'personal/feature-remove-mandatory-args'…
e87c5df 
… into feature-remove-mandatory-args
@asingamaneni
adding a test
0e7e030
@asingamaneni
Updating tests
05bb079
@asingamaneni
Updating tests-1
e313c90
@asingamaneni
updating docs
bdd74dd
@asingamaneni
updating docs
055d68b
@asingamaneni
Updating documentation
f324d35
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1bcce5a) 100.00% compared to head (a574b52) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        21    -1     
  Lines         1361      1394   +33     
=========================================
+ Hits          1361      1394   +33
Files Coverage Δ
spark_expectations/config/user_config.py 100.00% <ø> (ø)
spark_expectations/core/__init__.py 100.00% <100.00%> (ø)
spark_expectations/core/context.py 100.00% <100.00%> (ø)
spark_expectations/core/expectations.py 100.00% <100.00%> (ø)
...ns/notifications/push/spark_expectations_notify.py 100.00% <100.00%> (ø)
spark_expectations/secrets/__init__.py 100.00% <100.00%> (ø)
spark_expectations/sinks/__init__.py 100.00% <ø> (ø)
spark_expectations/sinks/plugins/base_writer.py 100.00% <ø> (ø)
spark_expectations/sinks/plugins/kafka_writer.py 100.00% <100.00%> (ø)
...ark_expectations/sinks/utils/collect_statistics.py 100.00% <ø> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Umeshsp22
Umeshsp22 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@Umeshsp22 Umeshsp22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit ca1ceb5 into main Sep 28, 2023
6 checks passed
@asingamaneni asingamaneni deleted the feature-remove-mandatory-args branch September 28, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umeshsp22 Umeshsp22 Umeshsp22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asingamaneni @Umeshsp22