Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Loosen pluggy version #94

Merged
merged 4 commits into from
May 29, 2024
Merged

[FEATURE] Loosen pluggy version #94

merged 4 commits into from
May 29, 2024

Conversation

mikita-sakalouski
Copy link
Contributor

@mikita-sakalouski mikita-sakalouski commented May 22, 2024

Description

Pluggy dependencies as follows pluggy = "^1"

Related Issue

#93

Motivation and Context

Currently pluggy version is hardcoded to pluggy = "1.0.0" which is not allowing to use latest versions of pytest.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit b615fd2 into Nike-Inc:main May 29, 2024
4 checks passed
cskcvarma pushed a commit to cskcvarma/spark-expectations that referenced this pull request Jul 22, 2024
* feat: loosen pluggy version

* feat: update poetry lock

* feat: update lock

* fix: pyspark version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants