6236/date time picker default (keystonejs#6237)

* remove empty timeValue validation * changeset * update unit test
Nikitoring · Sep 14, 2021 · 635a354 · 635a354
1 parent 272ebfc
commit 635a354
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/.changeset/fast-guests-tickle.md b/.changeset/fast-guests-tickle.md
@@ -0,0 +1,5 @@
+---
+'@keystone-next/fields': patch
+---
+
+Updated timestamp field to default time to 00:00 when no time is selected.
diff --git a/packages/fields/src/types/timestamp/views/__tests__/index.tsx b/packages/fields/src/types/timestamp/views/__tests__/index.tsx
@@ -33,7 +33,7 @@ describe('controller', () => {
           dateValue: formatISO(new Date(), { representation: 'date' }),
           timeValue: '',
         })
-      ).toBe(false);
+      ).toBe(true);
     });
   });
   describe('serialize', () => {
@@ -61,11 +61,15 @@ describe('controller', () => {
         [STUBCONFIG.path]: null,
       });
     });
-    it('should return null if no timeValue is specified', () => {
+    it('should return a valid ISO8601 string if no timeValue is specified but a valid date value is specified', () => {
       const { serialize } = controller(STUBCONFIG);
-      expect(serialize({ dateValue: '2020-10-20', timeValue: '' })).toStrictEqual({
-        [STUBCONFIG.path]: null,
-      });
+      expect(
+        Boolean(
+          parseISO(
+            serialize({ dateValue: '2020-10-20', timeValue: '' })[STUBCONFIG.path]
+          ).toISOString()
+        )
+      ).toBe(true);
     });
     it('should return a valid ISO8601 string if a valid time and date value are specified', () => {
       const { serialize } = controller(STUBCONFIG);

diff --git a/packages/fields/src/types/timestamp/views/index.tsx b/packages/fields/src/types/timestamp/views/index.tsx
@@ -155,7 +155,7 @@ export const controller = (
       return { dateValue: '', timeValue: '' };
     },
     serialize: ({ dateValue, timeValue }) => {
-      if (dateValue && timeValue && isValidISO({ dateValue, timeValue })) {
+      if (dateValue && isValidISO({ dateValue, timeValue })) {
         let formattedDate = constructTimestamp({ dateValue, timeValue });
         return { [config.path]: formattedDate };
       }
@@ -164,7 +164,6 @@ export const controller = (
     validate({ dateValue, timeValue }) {
       if (!dateValue && !timeValue) return true;
       if (!dateValue) return false;
-      if (!timeValue) return false;
       return isValidISO({ dateValue, timeValue });
     },
   };