Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to define region ends #104

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Add methods to define region ends #104

merged 2 commits into from
Sep 6, 2023

Conversation

Tracreed
Copy link
Contributor

@Tracreed Tracreed commented Aug 9, 2023

Add methods to PlayAudioCommand to define the end of a loop region and playback region.

  • loop_to
  • end_at

Also simplified the if let Some for PartialSoundSettings::apply

NiklasEi
NiklasEi approved these changes Sep 6, 2023
View reviewed changes
Copy link
Owner

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, this looks good 👍

@NiklasEi NiklasEi merged commit 251b96d into NiklasEi:main Sep 6, 2023
4 checks passed
NiklasEi added a commit that referenced this pull request Sep 6, 2023
@NiklasEi
Small documentation changes and changelog entry for #104
318317a
@Tracreed Tracreed deleted the add-settings-for-end-regions branch September 6, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tracreed @NiklasEi