Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are not linked properly when the url is not "clean" #10

Closed
dpshelio opened this issue Jan 15, 2021 · 1 comment
Closed

Images are not linked properly when the url is not "clean" #10

dpshelio opened this issue Jan 15, 2021 · 1 comment

Comments

@dpshelio
Copy link

For example, an article from the guardian newspaper shows right on the reader view but they don't show in different ebooks readers I tried.
Inspecting the created ebook shows they've been downloaded, however, there may be something wrong with the file names or that they don't have a "clear" extension.

i.e., the files are stored as:
2984.jpg?width=300&quality=45&auto=format&fit=max&dpr=2&s=268d9ccc054b66a94f0317ca4bf130ca
but if they are renamed to 2984.jpg (and changed in the content.opf and content.xhtml) then it works fine.

Is that something that could be fixed on loadResources?

@NiklasGollenstede
Copy link
Owner

Thanks for reporting. There was definitely something amiss here. Even though I am not sure whether the ePub files produced were strictly speaking correct or not, the readers I tried certainly also didn't like the query parameters in the file names.

The resources are being saved and referenced without the query parameters now. Loading these particular images (still?) fails in Chrome (based browsers), though. That's a more difficult issue, I think ...

But in Firefox it works. The beta build can be downloaded from GitHub now, and the main version on AMO was auto-approved (i.e. is available) as well.


And sorry for taking so long before looking at this. I had a rather important submission to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants