Skip to content

Commit

Permalink
Accept network interface name in addition to IP address in "Incoming …
Browse files Browse the repository at this point in the history
…Address" in web UI

Deluge & libtorrent actually accept both IP address and device/interface names as listen_interface:
deluge-torrent@540d557
it patched ui/ console & gkt3, but not web, this fixes it.

(Inspired by deluge-torrent#300)

(Translation should be ok: this string already exists)

Also, resync listen & outgoing widths: they hold the same data types.
  • Loading branch information
Niluge-KiWi committed Aug 27, 2024
1 parent 7660e2e commit 8f3d5f5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

- Python 3.6 support removed (Python >= 3.7)

### Web UI
- Accept network interface name in addition to IP adress in "Incoming Address"

## 2.1.1 (2022-07-10)

### Core
Expand Down
14 changes: 2 additions & 12 deletions deluge/ui/web/js/deluge-all/preferences/NetworkPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,6 @@
*/
Ext.namespace('Deluge.preferences');

// custom Vtype for vtype:'IPAddress'
Ext.apply(Ext.form.VTypes, {
IPAddress: function (v) {
return /^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/.test(v);
},
IPAddressText: 'Must be a numeric IP address',
IPAddressMask: /[\d\.]/i,
});

/**
* @class Deluge.preferences.Network
* @extends Ext.form.FormPanel
Expand All @@ -35,7 +26,7 @@ Deluge.preferences.Network = Ext.extend(Ext.form.FormPanel, {
fieldset = this.add({
xtype: 'fieldset',
border: false,
title: _('Incoming Address'),
title: _('Incoming Interface'),
style: 'margin-bottom: 5px; padding-bottom: 0px;',
autoHeight: true,
labelWidth: 1,
Expand All @@ -48,7 +39,6 @@ Deluge.preferences.Network = Ext.extend(Ext.form.FormPanel, {
fieldLabel: '',
labelSeparator: '',
width: 200,
vtype: 'IPAddress',
})
);

Expand Down Expand Up @@ -110,7 +100,7 @@ Deluge.preferences.Network = Ext.extend(Ext.form.FormPanel, {
name: 'outgoing_interface',
fieldLabel: '',
labelSeparator: '',
width: 40,
width: 200,
})
);

Expand Down

0 comments on commit 8f3d5f5

Please sign in to comment.