Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the Range Tick Provider Unit Test back #19

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Put the Range Tick Provider Unit Test back #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts_common/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ analyzer:
inference_failure_on_function_invocation: warning

# Probably OK
unreachable_from_main: warning
prefer_asserts_in_initializer_lists: warning
avoid_classes_with_only_static_members: warning
prefer_function_declarations_over_variables: warning
Expand Down
3 changes: 2 additions & 1 deletion charts_common/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ dependencies:

dev_dependencies:
austerity: ^1.2.0
mockito: ^5.0.0
build_runner: ^2.4.12
mockito: ^5.4.4
test: ^1.5.3
244 changes: 244 additions & 0 deletions charts_common/test/chart/cartesian/axis/range_tick_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,244 @@
// Copyright 2018 the Charts project authors. Please see the AUTHORS file
// for details.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// import 'package:mockito/mockito.dart';

import 'package:nimble_charts_common/src/chart/cartesian/axis/draw_strategy/base_tick_draw_strategy.dart';
import 'package:nimble_charts_common/src/chart/cartesian/axis/linear/linear_scale.dart';
import 'package:nimble_charts_common/src/chart/cartesian/axis/range_tick_provider.dart';
import 'package:nimble_charts_common/src/chart/cartesian/axis/scale.dart';
import 'package:nimble_charts_common/src/chart/cartesian/axis/spec/range_tick_spec.dart';
import 'package:nimble_charts_common/src/chart/cartesian/axis/spec/tick_spec.dart';
import 'package:nimble_charts_common/src/chart/cartesian/axis/tick_formatter.dart';
import 'package:nimble_charts_common/src/chart/common/chart_context.dart';
import 'package:test/test.dart';

import '../../../mox.mocks.dart';

class FakeNumericTickFormatter implements TickFormatter<num> {
int calledTimes = 0;

@override
List<String> format(
List<num> tickValues,
Map<num, String> cache, {
num? stepSize,
}) {
calledTimes += 1;

return tickValues.map((value) => value.toString()).toList();
}
}

void main() {
late ChartContext context;
late MockGraphicsFactory graphicsFactory;
late TickFormatter<num> formatter;
late BaseTickDrawStrategy<num> drawStrategy;
late LinearScale scale;

setUp(() {
context = MockChartContext();
graphicsFactory = MockGraphicsFactory();
formatter = MockNumericTickFormatter();
drawStrategy = MockDrawStrategy<num>();
scale = LinearScale()..range = const ScaleOutputExtent(0, 300);
});

group('scale is extended with range tick values', () {
test('values extend existing domain values', () {
final tickProvider = RangeTickProvider<num>([
const TickSpec<num>(20200601, label: '20200601'),
const TickSpec<num>(20200608, label: '20200608'),
const TickSpec<num>(20200615, label: '20200615'),
const RangeTickSpec<num>(
20200531,
label: 'Week 1',
rangeStartValue: 20200531,
rangeEndValue: 20200607,
),
const RangeTickSpec<num>(
20200607,
label: 'Week 2',
rangeStartValue: 20200607,
rangeEndValue: 20200614,
),
const RangeTickSpec<num>(
20200614,
label: 'Week 3',
rangeStartValue: 20200614,
rangeEndValue: 20200621,
),
]);

scale
..addDomain(20200601)
..addDomain(20200607);

expect(scale.dataExtent.min, equals(20200601));
expect(scale.dataExtent.max, equals(20200607));

tickProvider.getTicks(
context: context,
graphicsFactory: graphicsFactory,
scale: scale,
formatter: formatter,
formatterValueCache: <num, String>{},
tickDrawStrategy: drawStrategy,
orientation: null,
);

expect(scale.dataExtent.min, equals(20200531));
expect(scale.dataExtent.max, equals(20200621));
});

test('values within data extent', () {
final tickProvider = RangeTickProvider<num>([
const TickSpec<num>(20200601, label: '20200601'),
const TickSpec<num>(20200608, label: '20200608'),
const RangeTickSpec<num>(
20200531,
label: 'Week 1',
rangeStartValue: 20200531,
rangeEndValue: 20200607,
),
const RangeTickSpec<num>(
20200607,
label: 'Week 2',
rangeStartValue: 20200607,
rangeEndValue: 20200614,
),
]);

scale
..addDomain(20200401)
..addDomain(20200701);

expect(scale.dataExtent.min, equals(20200401));
expect(scale.dataExtent.max, equals(20200701));

tickProvider.getTicks(
context: context,
graphicsFactory: graphicsFactory,
scale: scale,
formatter: formatter,
formatterValueCache: <num, String>{},
tickDrawStrategy: drawStrategy,
orientation: null,
);

expect(scale.dataExtent.min, equals(20200401));
expect(scale.dataExtent.max, equals(20200701));
});
});

group('formatter', () {
test('is not called when all ticks have labels', () {
final tickProvider = RangeTickProvider<num>([
const TickSpec<num>(20200601, label: '20200601'),
const TickSpec<num>(20200608, label: '20200608'),
const RangeTickSpec<num>(
20200531,
label: 'Week 1',
rangeStartValue: 20200531,
rangeEndValue: 20200607,
),
const RangeTickSpec<num>(
20200607,
label: 'Week 2',
rangeStartValue: 20200607,
rangeEndValue: 20200614,
),
]);

final fakeFormatter = FakeNumericTickFormatter();

tickProvider.getTicks(
context: context,
graphicsFactory: graphicsFactory,
scale: scale,
formatter: fakeFormatter,
formatterValueCache: <num, String>{},
tickDrawStrategy: drawStrategy,
orientation: null,
);

expect(fakeFormatter.calledTimes, equals(0));
});

test('is called when one ticks does not have label', () {
final tickProvider = RangeTickProvider<num>([
const TickSpec<num>(20200601, label: '20200601'),
const TickSpec<num>(20200608, label: '20200608'),
const RangeTickSpec<num>(
20200531,
rangeStartValue: 20200531,
rangeEndValue: 20200607,
),
const RangeTickSpec<num>(
20200607,
label: 'Week 2',
rangeStartValue: 20200607,
rangeEndValue: 20200614,
),
]);

final fakeFormatter = FakeNumericTickFormatter();

tickProvider.getTicks(
context: context,
graphicsFactory: graphicsFactory,
scale: scale,
formatter: fakeFormatter,
formatterValueCache: <num, String>{},
tickDrawStrategy: drawStrategy,
orientation: null,
);

expect(fakeFormatter.calledTimes, equals(1));
});

test('is called when all ticks do not have labels', () {
final tickProvider = RangeTickProvider<num>([
const TickSpec<num>(20200601),
const TickSpec<num>(20200608),
const RangeTickSpec<num>(
20200531,
rangeStartValue: 20200531,
rangeEndValue: 20200607,
),
const RangeTickSpec<num>(
20200607,
rangeStartValue: 20200607,
rangeEndValue: 20200614,
),
]);

final fakeFormatter = FakeNumericTickFormatter();

tickProvider.getTicks(
context: context,
graphicsFactory: graphicsFactory,
scale: scale,
formatter: fakeFormatter,
formatterValueCache: <num, String>{},
tickDrawStrategy: drawStrategy,
orientation: null,
);

expect(fakeFormatter.calledTimes, equals(1));
});
});
}
11 changes: 11 additions & 0 deletions charts_common/test/mox.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import 'package:mockito/annotations.dart';
import 'package:nimble_charts_common/common.dart';

@GenerateNiceMocks([
MockSpec<ChartContext>(),
MockSpec<GraphicsFactory>(),
MockSpec<TextElement>(),
MockSpec<TickFormatter<num>>(as: #MockNumericTickFormatter),
MockSpec<BaseTickDrawStrategy>(as: #MockDrawStrategy),
])
void main() {}
Loading
Loading