Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AoT build failed with Angular 6 #86

Closed
qdelettre opened this issue Sep 6, 2018 · 4 comments
Closed

AoT build failed with Angular 6 #86

qdelettre opened this issue Sep 6, 2018 · 4 comments

Comments

@qdelettre
Copy link

Hi,

I'm using angular 6 with
"ngx-valdemort": "^0.1.0",

When building aot :
ERROR in node_modules/ngx-valdemort/ngx-valdemort.d.ts.ɵa.html(3,19): : Object is possibly 'null'.
@cexbrayat
Copy link
Member

cexbrayat commented Sep 6, 2018 •
edited
Loading

👋 Thank you for taking the time to open an issue.

I guess you are using strictNullChecks in your TypeScript configuration?

Update: I can indeed reproduce the issue. I submitted a PR with a fix.

cexbrayat added a commit that referenced this issue Sep 6, 2018
@cexbrayat
fix: aot build with strict null checks
193990a 
Fixes #86
@cexbrayat cexbrayat mentioned this issue Sep 6, 2018
Merged
@qdelettre
Copy link
Author

@cexbrayat I confirm. skipLibCheck is true in my tsconfig, so i guess i'm using stricNullChecks.

@jnizet jnizet closed this as completed in #87 Sep 7, 2018
@jnizet
Copy link
Member

jnizet commented Sep 7, 2018

@qdelettre I just released version 0.1.1. Please tell us if everything works fine with this release.

@qdelettre
Copy link
Author

@jnizet Aot build is fine 👍
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cexbrayat @jnizet @qdelettre