Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of devices introduced in 2024, minor clean up for iPad content #99

Closed
wants to merge 14 commits into from

Conversation

vincentneo
Copy link
Collaborator

@vincentneo vincentneo commented Sep 10, 2024

As per title.

Checklist:

  • iPad Air M2
  • iPad Pro M4
  • iPhone 16 series
  • Apple Watch Series 10
  • Update tests
  • Update CI

Supersedes #95, #96, #97

jminutaglio and others added 7 commits May 19, 2024 13:15
Adds:
- iPad Air M2 11 & 13
- iPad Pro M4 11 & 13
Co-Authored-By: jminutaglio <49879291+jminutaglio@users.noreply.github.com>
Co-Authored-By: jminutaglio <49879291+jminutaglio@users.noreply.github.com>
@vincentneo vincentneo self-assigned this Sep 10, 2024
@Nirma
Copy link
Owner

Nirma commented Sep 11, 2024

@vincentneo Looks great! I will fix CI later.

@Nirma
Copy link
Owner

Nirma commented Sep 23, 2024

@vincentneo Ok I updated the CI settings and the build and tests are passing now!

We can check that off the list.

@vincentneo
Copy link
Collaborator Author

I think I'm done, @Nirma if you have some time, please do take a look, in case I miss something!

@vincentneo vincentneo marked this pull request as ready for review September 24, 2024 16:38
@Nirma
Copy link
Owner

Nirma commented Sep 25, 2024

@vincentneo Looks great! I updated the CI settings in swift.yml mind rebasing with the latest develop?

That should get the build passing in CI.

@vincentneo
Copy link
Collaborator Author

@Nirma I think I messed up the rebasing, and somehow it's all on the main branch anyways. Is that alright? 😬

@Nirma
Copy link
Owner

Nirma commented Sep 30, 2024

@vincentneo Sure!

@vincentneo vincentneo closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants