Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fido-authenticator: “up needed” not signaled on NK3AM #96

Closed
robin-nitrokey opened this issue Oct 20, 2022 · 4 comments
Closed

fido-authenticator: “up needed” not signaled on NK3AM #96

robin-nitrokey opened this issue Oct 20, 2022 · 4 comments
Labels
app:fido bug Something isn't working

Comments

@robin-nitrokey
Copy link
Member

one curious thing is that I get the prompt to touch the device in the 3A NFC but it doesn't prompt with 3A mini
It seems if status == STATUS.UPNEEDED: # Waiting for touch this call in python-fido2 isn't called on the 3aMini

Nitrokey/pynitrokey#274

@robin-nitrokey robin-nitrokey added the bug Something isn't working label Oct 20, 2022
@runcom
Copy link
Contributor

runcom commented Oct 20, 2022

I also have the feeling that this #94 is also related to the issue here and the firmware is missing something - although I have no way to test what's going on at the hardware/firmware level
my feeling comes from the fact that the 3ANFC just works and perhaps this is related to nrf52 vs lpc55

@robin-nitrokey
Copy link
Member Author

In combination with #93, my guess that there is something wrong with the timers that trigger the ctaphid_keepalive and ui tasks: the CTAPHID_KEEPALIVE command signals STATUS_UPNEEDED, and ui should call the code that toggles the LED if it is blinking. @daringer do you have an idea why this could be the case? I will also try to debug this while working on #79.

@daringer
Copy link
Collaborator

looks like this is also fixed by #319

based on the original issue (Nitrokey/pynitrokey#274) I tested using nitropy fido2 verify and both behave identical now:

  • nk3am:
❯ nitropy fido2 verify
Command line tool to interact with Nitrokey devices 0.4.38
Enter PIN: 
Touch your authenticator device now...
/../
  • nk3an:
❯ nitropy fido2 verify
Command line tool to interact with Nitrokey devices 0.4.38
Enter PIN: 
Touch your authenticator device now...
/../

so, should we close this as fixed?

@robin-nitrokey
Copy link
Member Author

AFAIS this is fixed in current firmware releases, so I’m closing this issue. Please re-open if the problem occurs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:fido bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants