nrf: move set_waiting in button handling

[daringer]

This correctly positions the set_waiting() calls as suggested inside the issue.

Tested with the google-ctap2-test-suite + nk3am. It now properly outputs:

Please touch your security key!

[sosthene-nitrokey]

LGTM, though maybe it could have its place in set_status? 

Looking at it I also notice the call to self.set_status(ui::Status::WaitingForUserPresence); that is not present in the corresponding LPC55 implementation. Should it be there? The status is never restored by the firmware, and trussed already calls it before checking for user presence and then restores it.

[daringer]

Generally it could also be that this fix could solves this issue, too: #96

Looking at it I also notice the call to self.set_status(ui::Status::WaitingForUserPresence); that is not present in the corresponding LPC55 implementation. Should it be there? The status is never restored by the firmware, and trussed already calls it before checking for user presence and then restores it.

Yes, that's right, seen that too, would suggest to make this a part of #93 , where we have to investigate the LED behavior anyways - will add a note there.