Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on invalid base32 OTP secret #240

Closed
szszszsz opened this issue Apr 20, 2017 · 0 comments
Closed

Crash on invalid base32 OTP secret #240

szszszsz opened this issue Apr 20, 2017 · 0 comments
Assignees
@szszszsz

Comments

@szszszsz
Copy link
Member

szszszsz commented Apr 20, 2017 •
edited
Loading

App crashes on saving invalid base32 OTP secret.
App v1.0-beta.3
Details: #9 (comment)
@szszszsz szszszsz self-assigned this Apr 24, 2017
@szszszsz szszszsz mentioned this issue Oct 23, 2017
Closed
szszszsz added a commit that referenced this issue Oct 24, 2017
@szszszsz
Improve OTP expierience
22d91b8 
Code refactoring
Live validation of entered OTP secret key
Label showing the entered key is too long
Cleaning of user input and adding proper padding (fixes #280)
Catch all exceptions from parsing the secret key (fixes #240)
Possibly a solution for #239
Possibility of entering secret with spaces or hyphens
Added parsing by base32-crowford as a fallback

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szszszsz szszszsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szszszsz