nitrokey-app doesn't compile with latest libnitrokey

[ignatenkobrain]

https://github.com/Nitrokey/nitrokey-app/blob/master/CMakeLists.txt#L233

TARGET_LINK_LIBRARIES(nitrokey-app.debug
  ${EXTRA_LIBS}
  ${NK_LIB}-log
#  ${platform_specific_libs}
  Qt5::Widgets Qt5::Core Qt5::Gui
)

since Nitrokey/libnitrokey@bb7e087, nitrokey-log.so does not exist, so nitrokey-app.debug fails to compile.

[ignatenkobrain]

Nitrokey/libnitrokey@2ea2883 is related too

[ignatenkobrain]

P.S. I don't want to use bundled version of libnitrokey so just trying to hotfix it by adding some compiler definition (NO_LOG) doesn't work for me.

[szszszsz]

Hi!
You are correct. The changes should be synchronized with current master in next two days. There is already a patch waiting to merge on https://github.com/Nitrokey/nitrokey-app/releases/tag/v1.2-beta.2. You can try to test it instead in the meantime.

[ignatenkobrain]

@szszszsz hmm, can you link a patch/pull-request please? it seems that v1.2-beta.2 doesn't contain required changes..

[szszszsz]

Indeed, sorry, I will correct this asap.
So, to rephrase, you would like to use shared libnitrokey library (from other package)?
To make it so I think this line will have to be removed in hotfix: https://github.com/Nitrokey/nitrokey-app/blob/v1.2-beta.2/CMakeLists.txt#L35 and with this CMake should issue linking with on-system library (not tested yet).

[ignatenkobrain]

@szszszsz yes, I package libnitrokey separately which used to have 2 libraries at the same time =) I already have all hacks in place to use system-wide libnitrokey =)

[szszszsz]

Great!
I have pushed the changes to v1.2-beta branch. Could you test it?

[ignatenkobrain]

Apparently I did same thing some time ago.. ;) https://src.fedoraproject.org/rpms/nitrokey-app/c/df8881ad4831ae1c8ef4a4c5fa223f7de42f7545

So I'm sure it works. Would be cool if you could tag some new beta version so I could update fedora to it.

[szszszsz]

Done! See v1.2-beta.3 tag.
Edit: indeed, the diffs are quite similar :-)

[ignatenkobrain]

Thanks a lot! Just built and submitted updates for F27+