Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement better detection of unpartitioned encrypted volume #42

Closed
szszszsz opened this issue Apr 19, 2016 · 2 comments
Closed

Implement better detection of unpartitioned encrypted volume #42

szszszsz opened this issue Apr 19, 2016 · 2 comments
Labels
prio:medium

Comments

@szszszsz
Copy link
Member

Implement better detection of unpartitioned encrypted volume. Currently it is checked through existence of a symlink /dev/nitrospace (created by udev, pull #25). It might be better to check it reading /proc (which is already implemented).
@Belatronix
Copy link
Contributor

Use the force Luke!
And this force are kernel triggered udev events. What is the reason to reinvent the wheel? Udev was developed exactly for this.

@szszszsz
Copy link
Member Author

Hi Belatronix!

After reconsideration I think you are right. Checking through udev could be the best method. However I would like to test it more to ensure all cases are covered. I will close the issue for now to not clutter the view and reopen in case I would have any suggestions. Thanks for your work!

szszszsz added a commit that referenced this issue Sep 11, 2017
@szszszsz
Merge pull request #42 from Nitrokey/13-storage_pro_cmds
82a0fc2 
Support Pro stick commands on Storage device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Belatronix @szszszsz