Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check feedback for firmware password changing with Nitrokey Storage #97

Closed
szszszsz opened this issue Jun 24, 2016 · 5 comments
Closed

Check feedback for firmware password changing with Nitrokey Storage #97

szszszsz opened this issue Jun 24, 2016 · 5 comments
Assignees
@szszszsz
Labels
prio:high

Comments

@szszszsz
Copy link
Member

Currently no success or failure message is shown while changing firmware password
@szszszsz szszszsz self-assigned this Jun 25, 2016
szszszsz added a commit that referenced this issue Jun 25, 2016
@szszszsz
Return proper feedback for changing firmware password (issue #97)
bc3ce95 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

szszszsz commented Jun 25, 2016 •
edited
Loading

To investigate. I have modified the app, but it looks like it works only on first change (=> first change after factory reset, device reinsertion and application restart are not helping). Later password changes are always reported by device as failed (bc3ce95#diff-3301dce0d4fa3f36ee73aa1a548416e0R2401). Could you check @rudbo ?

@rudbo
Copy link
Contributor

rudbo commented Jun 26, 2016

I can't find the problem with my system:
Win7, Firmware 0.36, App Mainline
The firmware always change the password an send the correct status

@szszszsz
Copy link
Member Author

Thank you for checking!

@szszszsz
Copy link
Member Author

szszszsz commented Jun 27, 2016 •
edited
Loading

@rudbo Unfortunately I can confirm your results only partially. It is working for me as I have described in previous comment (only on first successful change) on both Windows 8.0 (compiled with Qt's mingw 5.3) and Ubuntu 16.04. I was using branch issue_97_firmware_password_feedback (the only differences in code with mainline are debug prints and feedback logic).
Furthermore I cannot set update mode on device with any password (default or just set) after change.

This was referenced Jun 27, 2016
Closed
Closed
szszszsz added a commit that referenced this issue Jun 28, 2016
@szszszsz
Return proper feedback for changing firmware password (issue #97)
64e7283 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz mentioned this issue Jun 28, 2016
Merged
szszszsz added a commit that referenced this issue Jun 28, 2016
@szszszsz
Merge pull request #99 from Nitrokey/issue_97_firmware_password_feedb…
5ec94e6 
…ack_no_debug

Fix for issue #97
Code enables proper feedback receiving from device
Tested on Ubuntu 16.04 and Windows 8.
There are some issues however with sub-sequential password changing, possibly caused by firmware (Nitrokey/nitrokey-storage-firmware#11).
@szszszsz szszszsz removed the ongoing label Jun 28, 2016
@szszszsz
Copy link
Member Author

Merged to master password feedback code without debug code.

szszszsz added a commit that referenced this issue Jun 29, 2016
@szszszsz
Merge pull request #102 from Nitrokey/issue_97_firmware_password_feed…
795f942 
…back_no_debug_2

Allow firmware password to have at most CS20_MAX_UPDATE_PASSWORD_LEN
Issue #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szszszsz szszszsz

Labels
prio:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jans23 @rudbo @szszszsz