Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring in an attempt to fix #142 #149

Merged
merged 30 commits into from
Sep 21, 2016
Merged

Code refactoring in an attempt to fix #142 #149

merged 30 commits into from
Sep 21, 2016

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Sep 21, 2016 •
edited
Loading

Fixes #146
In search for a cause of #142 a global code refactoring has been performed.

  • move from heap to stack (use auto variables instead of new/delete)
  • code simplifying
  • take care of exact bytes copying (memcpy)
  • use sizeof instead of hardcoded variables (for uin8_t)
  • use agregate initialization instead of memset
  • make lazy initialized singleton from global variable (csApplet)

@szszszsz
Fixing crashes on stack 1
da695c2 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Fixing crashes on stack 2
0f991a6 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Fixing crashes on stack 3
03bcc7a 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Fixing crashes on stack 4
c0e4e4d 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Fixing crashes on stack 5 clang analyzer
feb263f 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Fixing crashes on stack 6 valgrind #142
7aca03f 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Invalidate internal user password flag on wrong password status when …
30b558a 
…authenticating user

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Use stack for declaring cmd object. Code refactoring/simplifying.
f4b6d33 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Code reformat
2be11ae 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Remove unnecessary comments. Simplify code. Care for copying correct …
9e7dd0c 
…amount of data.

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Code cleaning command::generateCRC
905aebc 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Use array initialization instead of memset
1f425da 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Code refactoring device::eraseSlot - use stack, simplify code
d41386a 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Allow NK Pro user to erase OTP slots sequentially without reentering …
c6cb654 
…to Configuration window #146

Increase waiting delay after sending eraseSlot command to avoid crc error.

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Use mutexed singleton for csApplet instead of raw pointer
ac94a0e 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
No need to use QObject here
c301066 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Set global parent to null. Do not use detailed yes or no box.
81cd42d 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Code refactoring - small improvements
6843629 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Use crc code from Command class
1e85490 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Update docs for device::sendCommand
18e3231 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
code reformat
93f7bf3 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Stack debug (asan) - writeToTotpSlot and getPasswordRetryCount in dev…
0083408 
…ice.cpp

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Remove parent parameter for csApplet dialogs (it was not used)
64fd5f5 
Q_OBJECT not needed here

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Update PinDialog tries count on each iteration during sequential erasing
eb34cf9 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Increase timer delays
a889121 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Use mutex while checking is device connected
8aa01c0 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Refactor and remove initial time setting for TOTP on check connection.
494b17a 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Refactoring: use array size instead of hardcoded value. Remove commen…
bfc6b46 
…ted code.

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Refactoring device::readSlot : extract array index to variable
d334d5a 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Enable back initial time set for NK Pro and TOTP
aa3630c 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz merged commit 1057ca5 into master Sep 21, 2016
@szszszsz szszszsz deleted the issue_142-crashes_on_messagebox branch September 21, 2016 13:53
@jans23 jans23 mentioned this pull request Sep 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szszszsz