Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 60 handle both firmwares for hotp #64

Merged
merged 5 commits into from
May 16, 2016
Merged

Issue 60 handle both firmwares for hotp #64

merged 5 commits into from
May 16, 2016

Conversation

szszszsz
Copy link
Member

Fixes Issue #60
Handling both Nitrokey Pro and Storage counters

@szszszsz
Handle HOTP counter for both Nitrokey Pro (ulong) and Storage (text)
5220df1 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Check HOTP counter text length and save only 7 digits or issue warning
fbc017d 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Read back HOTP counter value for Nitrokey Pro
35a69a1 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Fix: check ulong for HOTP counter, not long
e28c460 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Limit counter digits count to 7 for Nitrokey Storage
640f2a9 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Tested on Ubuntu 16.04 with both Nitrokeys Storage and Pro
Tested by:

  • setting 0,3,7 counter values with RFC example's secret and comparing values;
  • setting maximum counter value and requesting HOTP code;

@szszszsz szszszsz merged commit 302dadb into master May 16, 2016
@szszszsz szszszsz deleted the issue_60-handle_both_firmwares_for_hotp branch May 16, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szszszsz