Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 no feedback after changing password #67

Merged
merged 15 commits into from
May 18, 2016

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented May 17, 2016

This is a fix for issue #38

Fixed feedback for changing firmware, user and admin passwords for NK Storage.
Left to do:

  • feedback for resetting user password
  • feedback for setting update password

Tested on Ubuntu 16.04 with NK Storage.

…NK Storage)

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz self-assigned this May 17, 2016
…out dialog does show current retry counts (#66)

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz force-pushed the issue_38-No_feedback_after_changing_password branch from e14152b to d29a9da Compare May 17, 2016 14:39
@szszszsz
Copy link
Member Author

Also closes #65 and #66

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
…ssword

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Done resetting user password

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz force-pushed the issue_38-No_feedback_after_changing_password branch from e60f001 to 4c4959a Compare May 17, 2016 18:30
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Same should be done for Nitrokey Pro - another issue will be opened.

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Left to do feedback when entering wrong user PIN while unlocking encrypted volume.

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
…olumes unlocking

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz merged commit e23f879 into master May 18, 2016
@szszszsz
Copy link
Member Author

Closes issue #38

Tested on Ubuntu 16.04 with NK Storage (FW 0.31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant