-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nix develop: Add convenience flags for running specific phases
For example, for building the Nix flake, you would do: $ nix develop --configure $ nix develop --install $ nix develop --installcheck
- Loading branch information
Showing
1 changed file
with
53 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f156513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to add nixpkgs-specific functionality like this?
f156513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-shell
has always been nixpkgs-specific (e.g. it assumes the existence of$stdenv/setup
).f156513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should error when multiple phases are set since
nix develop --configure --build
is justnix develop --build
unpack might also be useful here when you're not in the correct directory (for instance,
nix develop nixpkgs#git --unpack
)f156513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it has, but that also caused me trouble in the past! (such as when i wanted to switch the propagated deps files to use newline or
\0
as a separator.)This change, in particular, would make something like NixOS/rfcs#32 harder to do, right?
f156513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should avoid the need for NixOS/rfcs#32, which is nice since it's a breaking change.
f156513
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewbauer But see the secondary goal, about custom phases still having pre and post hooks be run. It's still useful for that.