-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constant space addToStoreFromDump
and deduplicate code
#3801
Commits on Jul 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9ec1004 - Browse repository at this point
Copy the full SHA 9ec1004View commit details -
Crudely make
addToStoreFromDump
takeSource
not stringI just as little beyond the type as possible, so the implementation changes this enables can be reviewed separately.
Configuration menu - View commit details
-
Copy full SHA for c86fc3a - Browse repository at this point
Copy the full SHA c86fc3aView commit details -
The downsides is that the coroutine has byte-by-byte loop transfer. Will fix that next.
Configuration menu - View commit details
-
Copy full SHA for 9de96ef - Browse repository at this point
Copy the full SHA 9de96efView commit details -
LocalStore::addToStoreFromDump copy in chunks
Rather than copying byte-by-byte, we let the coroutine know how much data we would like it to send back to us.
Configuration menu - View commit details
-
Copy full SHA for 592851f - Browse repository at this point
Copy the full SHA 592851fView commit details -
Fix localhost::addToStore(...Path...)
We were calculating the nar hash wrong when the file ingestion method was flat. I don't think there's anything we can do in that case but dump the file again, so that's what I do. As an optomization, we again could reuse the original dump for just the recursive and non-sha256 case, but I rather do that after this fix, and after my other PRs which deduplicate this code.
Configuration menu - View commit details
-
Copy full SHA for 8173e7b - Browse repository at this point
Copy the full SHA 8173e7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 650c2c6 - Browse repository at this point
Copy the full SHA 650c2c6View commit details
Commits on Jul 15, 2020
-
Merge remote-tracking branch 'obsidian/fix-add-to-star-narhash' into …
…from-dump-stream
Configuration menu - View commit details
-
Copy full SHA for aff69e2 - Browse repository at this point
Copy the full SHA aff69e2View commit details -
Revert "Revert "LocalStore::addToStore(srcPath): Handle the flat case""
This reverts commit cff2157.
Configuration menu - View commit details
-
Copy full SHA for d087cf4 - Browse repository at this point
Copy the full SHA d087cf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b7421 - Browse repository at this point
Copy the full SHA 64b7421View commit details -
Get rid of
LocalStore::addToStoreCommon
I got it to just become `LocalStore::addToStoreFromDump`, cleanly taking a store and then doing nothing too fancy with it. `LocalStore::addToStore(...Path...)` is now just a simple wrapper with a bare-bones sinkToSource of the right dump command.
Configuration menu - View commit details
-
Copy full SHA for bc10964 - Browse repository at this point
Copy the full SHA bc10964View commit details -
Revert "LocalStore::addToStoreFromDump copy in chunks"
This reverts commit 592851f. We don't need this extra feature anymore
Configuration menu - View commit details
-
Copy full SHA for 5602637 - Browse repository at this point
Copy the full SHA 5602637View commit details
Commits on Jul 16, 2020
-
We use this to simplify `LocalStore::addToStoreFromDump`. Also, hope I fixed build error with old clang (used in Darwin CI).
Configuration menu - View commit details
-
Copy full SHA for 3dcca18 - Browse repository at this point
Copy the full SHA 3dcca18View commit details
Commits on Jul 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for eab945f - Browse repository at this point
Copy the full SHA eab945fView commit details
Commits on Jul 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9aae179 - Browse repository at this point
Copy the full SHA 9aae179View commit details -
Merge branch 'fix-and-document-addToStoreSlow' of github.com:obsidian…
…systems/nix into from-dump-stream
Configuration menu - View commit details
-
Copy full SHA for 5a37413 - Browse repository at this point
Copy the full SHA 5a37413View commit details