-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable aarch64-darwin in release.nix #4867
Conversation
I tested to build hello in |
I don't know if this will work, given that the 2.3 branch is built against Nixpkgs 20.03: https://hydra.nixos.org/jobset/nix/maintenance-2.3#tabs-configuration |
Could we bump that to 21.05? |
It would not work. So we would have to bump that to 21.05. Or back port aarch64-darwin support, but I don't think that is a good idea. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
nix-2.3.12 can built against 21.05. It was needed for |
Note that this is the last step needed to get out-of-the-box Apple Silicon support in Nix. @kloenk could you rebase? |
Will rebase tomorrow |
75f787d
to
474a4de
Compare
nix rebased, now building the rebased nix. Will report if it works as edit to this comment. EDIT: works well on my machine (unstable daemon). |
@edolstra shall we give it a go and see what hydra says? |
@kloenk you also need to add aarch64-darwin to line 318. |
474a4de
to
29e8db9
Compare
@domenkozar: |
@edolstra any objections to merge this and see if it works? |
Yes, we can try. Though ideally we shouldn't change the Nixpkgs branch for a stable Nix release, since it could cause incompatible changes in the Nix binary tarballs that we provide (e.g. a Glibc upgrade causing NSS problems). |
I wonder if we could test how old glibc it supports? |
@kloenk there's an evaluation error for installerScript: https://hydra.nixos.org/eval/1676684#tabs-errors |
Will probably have to make the fixes in nixpkgs, then update the reference to nixpkgs which is able to evalutate for the new platforms, I had to do something similar for fixing staging-next tarball. |
Ah, the channel is hardcoded in Hydra and I don't have permissions for nix project. @edolstra could you set 21.05 channel at https://hydra.nixos.org/jobset/nix/maintenance-2.3#tabs-configuration |
Done. |
This enables aarch64-darwin builds, on top of nixpkgs-21.05-small (NixOS/nixpkgs#105026)