Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace writeShellScriptBin in prime.nix with enableOffloadCmd #727

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

Guanran928
Copy link
Contributor

option introduced in this commit:
NixOS/nixpkgs@2a7130d

Description of changes
Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92
Copy link
Member

Mic92 commented Sep 17, 2023

@bors merge

@Mic92
Copy link
Member

Mic92 commented Sep 17, 2023

We can potentially check for nixpkgs.config.nvidia.acceptLicense && nixpkgs.config.allowUnfree here? I wouldn't mind allowing unfree in this repo, but it might get hairy if I ever want to nixos-hardware build on hydra.

@Guanran928
Copy link
Contributor Author

I'm unfamiliar with Nix (and Git) and I don't actually know what's going on here. :/
Can you show me how to do it exactly? And I've enabled Allow edits by maintainers.

@Mic92
Copy link
Member

Mic92 commented Sep 18, 2023

Looks like your change doesn't affect the build issue here at all.

@Mic92
Copy link
Member

Mic92 commented Sep 18, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d53069d

@Mic92
Copy link
Member

Mic92 commented Sep 18, 2023

Fix applied in https://github.com/NixOS/nixos-hardware/pull/731/files

@mergify mergify bot merged commit d53069d into NixOS:master Sep 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants