Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lazy_static with std::sync::LazyLock #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willbush
Copy link
Member

@willbush willbush commented Oct 30, 2024

lazy_static is no longer needed. We can just use this from std:

https://doc.rust-lang.org/std/sync/struct.LazyLock.html

note: no difference in compile times before / after on my machine. Think compile times are dominated by clap (edit actually maybe regex-syntax in regex crate which can't be removed easily).

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #122 is currently being worked on by a new contributor, let's wait with merging this one a bit until that's done, so as to not require them to resolve a merge conflict, but this sounds good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants