python3{11,12}Packages.nose: drop (#348699)

NixOS · Oct 15, 2024 · 00d748f · 00d748f
2 parents 0a454ad + 9c2358e
commit 00d748f
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 653 deletions.
diff --git a/nixos/doc/manual/release-notes/rl-2411.section.md b/nixos/doc/manual/release-notes/rl-2411.section.md
@@ -597,6 +597,9 @@
   lists by default. Backwards-compatible behavior can be enabled with
   `atomsCoercedToLists`.
 
+- `python3Packages.nose` has been removed, as it has been deprecated and unmaintained for almost a decade and does not work on Python 3.12.
+  Please switch to `pytest` or another test runner/framework.
+
 ## Other Notable Changes {#sec-release-24.11-notable-changes}
 
 <!-- To avoid merge conflicts, consider adding your item at an arbitrary place in the list instead. -->

diff --git a/pkgs/development/python-modules/nose/0001-nose-python-3.12-fixes.patch b/pkgs/development/python-modules/nose/0001-nose-python-3.12-fixes.patch
diff --git a/pkgs/development/python-modules/nose/default.nix b/pkgs/development/python-modules/nose/default.nix
diff --git a/pkgs/development/python-modules/nose2pytest/default.nix b/pkgs/development/python-modules/nose2pytest/default.nix
@@ -5,8 +5,7 @@
   fetchpatch2,
   setuptools,
   fissix,
-  pytestCheckHook,
-  nose,
+  pytest,
 }:
 
 let
@@ -37,16 +36,13 @@ buildPythonPackage {
 
   build-system = [ setuptools ];
 
-  dependencies = [ fissix ];
-
-  nativeCheckInputs = [
-    pytestCheckHook
-    nose
+  dependencies = [
+    fissix
+    pytest
   ];
 
-  preCheck = ''
-    export HOME=$(mktemp -d)
-  '';
+  # Tests depend on nose!
+  doCheck = false;
 
   pythonImportsCheck = [ "nose2pytest.assert_tools" ];
 

diff --git a/pkgs/development/python-modules/pytest/7.nix b/pkgs/development/python-modules/pytest/7.nix
@@ -22,7 +22,6 @@
   argcomplete,
   hypothesis,
   mock,
-  nose,
   pygments,
   requests,
   xmlschema,
@@ -66,7 +65,6 @@ let
         attrs
         hypothesis
         mock
-        nose
         pygments
         requests
         setuptools

diff --git a/pkgs/top-level/python-aliases.nix b/pkgs/top-level/python-aliases.nix
@@ -358,6 +358,7 @@ mapAliases ({
   net2grid = gridnet; # add 2022-04-22
   nghttp2 = throw "in 1.52.0 removed deprecated python bindings."; # added 2023-06-08
   ninja-python = ninja; # add 2022-08-03
+  nose = throw "nose has been removed since it has been deprecated and unmaintained for almost a decade and does not work on Python 3.12; please switch to pytest or another test runner/framework"; # added 2024-07-28
   nose3 = throw "nose3 has been removed since it is unmaintained and does not work with Python 3.12"; # added 2024-07-28
   nosejs = throw "nosejs has been removed since it has not been maintained for 15 years and there are no dependent packages"; # added 2024-05-21
   nose-cov = throw "nose-cov has been removed, it was archived and unmaintained since 2012"; # added 2024-05-21

diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
@@ -9027,8 +9027,6 @@ self: super: with self; {
 
   normality = callPackage ../development/python-modules/normality { };
 
-  nose = callPackage ../development/python-modules/nose { };
-
   nose2 = callPackage ../development/python-modules/nose2 { };
 
   nose2pytest = callPackage ../development/python-modules/nose2pytest { };