-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv fails to build on darwin #15881
Comments
I'd bisect and try to understand what broke it |
@copumpkin alright. I'll try tomorrow |
Actually that was quite fast:
|
Cool, thanks! @ttuegel, have any ideas why that would've changed something? The issue appears to be that your rpath change caused one of our builds to hold onto more of the bootstrap tools than we wanted it to. |
@copumpkin @ttuegel stdenv not building is quite a blocker - any chance we could revert this for now until we have a real solution? I don't understand anything about the details but it appears to be "only" an optimization to avoid some guess work so losing that for a bit might not be that bad? |
I'll go ahead and revert it, but I'll need a Darwin user to fix it for me (since I can't test). Probably you just need to filter I'm also a little startled that this causes more paths to be retained. |
Actually, nobody should try to resurrect that patch. It goes against the CMake philosophy. The CMake philosophy is probably wrong, but it's our job to conform. |
@ttuegel that seems worth a discussion on the issue tracker perhaps? A lot of things that might make "philosophical" sense in a broader unix community probably make less sense in Nix, so I wouldn't take such stances too dogmatically. |
I definitely know that in the past I've been annoyed at CMake for trying to be too clever, so patches to it that make it less clever are great in my book. |
The patch overrides any attempt by any CMake module to do anything whatsoever to the RPATH. I did this for Qt because Qt's CMake modules are fundamentally incompatible with multiple outputs because of things they do with RPATH. However, it also stops packages written by people who know what they're doing with CMake from doing smart things with RPATH. Like LLVM. |
Perhaps I'll just go back to hoping CMake magically disappears 😄 |
At least CMake is documented. 😃 Like CMake, autoconf and friends will let developers do any crazy-silly thing they want and we as packagers are doomed to never find the right setting to override it. Although, I think nobody who uses autoconf even knows how it works, so most developers are unlikely to do crazy stuff. I think in this case I can just make the change I need to |
Issue description
stdenv fails to build on darwin
Steps to reproduce
nix-build -A stdenv
Technical details
\cc @zimbatm @LnL7 @copumpkin any ideas?
The text was updated successfully, but these errors were encountered: