-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md: Add section on becoming a maintainer #171557
Labels
0.kind: enhancement
Add something new
Comments
The Nixpkgs Manual has that section. |
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Nov 2, 2022
Nevertheless the section in the manual is helpful, imo having a comment in CONTRIBUTING seems like a good idea. Additionally I would suggest that both sources should mention that as per comment it might be preferrable to have the commits ordered like this:
this also helps to easier squash required changes to the actual commit. |
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Aug 25, 2023
VuiMuich
added a commit
to VuiMuich/nixpkgs
that referenced
this issue
Aug 28, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I got some feedback after a review on a PR (#161404 (comment)) that it's not very clear that adding yourself as a maintainer in maintainers.nix should be a separate commit.
It might be nice to add a small section to CONTRIBUTING explaining the (simple) process, or maybe linking from there to the manual.
The text was updated successfully, but these errors were encountered: