Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect musl/glibc correctly in meta.platforms for binary GHCs #212098

Open
sternenseemann opened this issue Jan 22, 2023 · 0 comments
Open

Reflect musl/glibc correctly in meta.platforms for binary GHCs #212098

sternenseemann opened this issue Jan 22, 2023 · 0 comments
Labels
0.kind: enhancement Add something new 6.topic: haskell 6.topic: musl Running or building packages with musl libc

Comments

@sternenseemann
Copy link
Member

We should be able to leverage #195294 (which allows adding proper lib.platforms to the meta.platforms list to my understanding) in order to get rid of the following HACK:

# HACK: since we can't encode the libc / abi in platforms, we need
# to make the platform list dependent on the evaluation platform
# in order to avoid eval errors with musl which supports less
# platforms than the default libcs (i. e. glibc / libSystem).
# This is done for the benefit of Hydra, so `packagePlatforms`
# won't return any platforms that would cause an evaluation
# failure for `pkgsMusl.haskell.compiler.ghc922Binary`, as
# long as the evaluator runs on a platform that supports
# `pkgsMusl`.
platforms = builtins.attrNames ghcBinDists.${distSetName};
hydraPlatforms = builtins.filter (p: minimal || p != "aarch64-linux") platforms;

cc @amjoseph-nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 6.topic: haskell 6.topic: musl Running or building packages with musl libc
Development

Successfully merging a pull request may close this issue.

2 participants