Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilers/ghc: reflect musl/glibc correctly in meta.platforms #212188

Closed
wants to merge 5 commits into from
Closed

compilers/ghc: reflect musl/glibc correctly in meta.platforms #212188

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2023 •
edited by ghost
Loading

Description of changes

Closes #212098

Includes

Cc: @sternenseemann

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jan 22, 2023

Before:

$ nix eval --impure --expr 'with (import ./. {}); haskell.compiler.ghc924Binary.meta.platforms'
[ "aarch64-darwin" "aarch64-linux" "i686-linux" "x86_64-darwin" "x86_64-linux" ]

After:

$ nix eval --impure --expr 'with (import ./. {}); lib.concatMap lib.systems.doublesFromPattern haskell.compiler.ghc924Binary.meta.platforms'
[ "aarch64-darwin" "aarch64-linux" "i686-linux" "x86_64-darwin" "x86_64-linux" ]

@ghost ghost marked this pull request as draft January 23, 2023 00:06
@ghost ghost marked this pull request as ready for review January 23, 2023 00:17
@ofborg ofborg bot requested a review from expipiplus1 January 23, 2023 00:30
@ghost ghost marked this pull request as draft January 23, 2023 01:12
@ghost ghost marked this pull request as ready for review January 23, 2023 01:16
@ghost ghost requested a review from piegamesde as a code owner January 23, 2023 01:16
@github-actions github-actions bot added 6.topic: stdenv Standard environment and removed 6.topic: stdenv Standard environment labels Jan 23, 2023
@ghost
Copy link
Author

ghost commented Mar 10, 2023

Rebased.

@ghost
Copy link
Author

ghost commented Jul 12, 2023

Rebased.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jul 12, 2023
@sternenseemann sternenseemann mentioned this pull request Aug 2, 2023
Merged
12 tasks
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/ghc/metaPlatforms branch January 23, 2024 06:48
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

@nbp nbp Awaiting requested review from nbp

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@piegamesde piegamesde Awaiting requested review from piegamesde

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: lib The Nixpkgs function library 6.topic: stdenv Standard environment 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reflect musl/glibc correctly in meta.platforms for binary GHCs
0 participants