Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-generate-config suggests invalid Nix #221510

Closed
schuelermine opened this issue Mar 16, 2023 · 1 comment · Fixed by #221576
Closed

nixos-generate-config suggests invalid Nix #221510

schuelermine opened this issue Mar 16, 2023 · 1 comment · Fixed by #221576
Labels
0.kind: bug Something is broken

Comments

@schuelermine
Copy link
Contributor

Describe the bug

nixos-generate-config generates the following commented out invalid syntax:

  # Configure keymap in X11
  # services.xserver.layout = "us";
  # services.xserver.xkbOptions = {
  #   "eurosign:e";
  #   "caps:escape" # map caps to escape.
  # };

Perhaps = [ ... ] was intended?

Steps To Reproduce

Steps to reproduce the behavior:

  1. nixos-generate-config
  2. View configuration.nix

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

  • system: "x86_64-linux"
  • host os: Linux 5.15.102, NixOS, 22.11 (Raccoon), 22.11.3184.9b8e5abb183
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.11.1
  • channels(root): "nixos-22.11.3184.9b8e5abb183"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos
@paumr
Copy link
Contributor

paumr commented Mar 17, 2023

Nice catch!
xkbOptions requires a comma separated string.

I submitted a PR which will fix this issue.

@schuelermine schuelermine changed the title nixos-generate-config suggest invalid Nix nixos-generate-config suggests invalid Nix Mar 17, 2023
RaitoBezarius pushed a commit that referenced this issue Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants