Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: use new cargo fetcher #357257

Closed
Bot-wxt1221 opened this issue Nov 19, 2024 · 2 comments
Closed

treewide: use new cargo fetcher #357257

Bot-wxt1221 opened this issue Nov 19, 2024 · 2 comments
Labels
3.skill: sprintable A larger issue which is split into distinct actionable tasks 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: rust

Comments

@Bot-wxt1221
Copy link
Member

Bot-wxt1221 commented Nov 19, 2024

TODO: @emilazy suggest my script should be reviewd independently and all output should be reduced.

She has mentioned that FOD hash attack is possible.

This is a tracking issue to replace #356862.

These are from old PR:

Already done. We should run nixpkgs-review to check if some package have different Cargo.lock when building and in nixpkgs, like veloren.

I have writen a script to update it automatically.

Now It can solve:

cargoLock = {
  lockFile = xxx;
  outputhahes = {xxx};
};
cargoLock.lockFile = xxx;
cargoLock.outputHashes = {xxx};

Script: https://github.com/Bot-wxt1221/cargo-rename

Usage:

Compile with gcc. Make sure fetch-cargo can be exec. Exec with a xx/pkgs/by-name/xx/xx/package.nix

cc #327063

#349360

Step to reduce:

  1. Generate a file list with cargoLock:
rg "cargoLock" --files-with-matches > filewithcargoLock

cat filewithcargoLock | rev | cut -d / -f 2|rev > packagename
  1. run update-all

useFetchCargoVendor

@Bot-wxt1221
Copy link
Member Author

Now All PR have split nixfmt into one.

@Aleksanaa
Copy link
Member

@emilazy do you agree with the step of changing to fetchCargoVendor first, before we investigate one lockfile mechanism?

@tomodachi94 tomodachi94 added the 3.skill: sprintable A larger issue which is split into distinct actionable tasks label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.skill: sprintable A larger issue which is split into distinct actionable tasks 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems 6.topic: rust
Projects
None yet
Development

No branches or pull requests

4 participants