rustPlatform.fetchCargoVendor: retry fetching tarballs #357262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
This is need for #357257. |
|
JohnRTitor
reviewed
Nov 19, 2024
| sha256_hash = hashlib.sha256() | ||
| with requests.get(url, stream=True) as response: | ||
| with session.get(url, stream=True) as response: |
There was a problem hiding this comment.
I liked the solution from the other PR, was pretty straightforward
But I guess this is more resilent
Mic92
approved these changes
Nov 19, 2024
JohnRTitor
approved these changes
Nov 19, 2024
13 tasks
1 task
JohnRTitor
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if a backup_factor of 0.5 is too high.
@JohnRTitor
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.